Re: PATCH: EXTENSION keyword not supported by pgAdmin3

From: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: EXTENSION keyword not supported by pgAdmin3
Date: 2011-12-02 04:36:11
Message-ID: CAG7mmoyKKmRJ9dZUTqwBwPiWpE1=2isD-D0ZFbb7XUpOowD0PA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Please find the updated patch.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company<http://www.enterprisedb.com>

*http://www.linkedin.com/in/asheshvashi*<http://www.linkedin.com/in/asheshvashi>

On Thu, Dec 1, 2011 at 7:02 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> I did send it to you, a couple of emails ago.
>
>
> On Thu, Dec 1, 2011 at 1:30 PM, Ashesh Vashi <
> ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>> Can you please share you dump file?
>> I would like to experiment with it...
>>
>> --
>>
>> Thanks & Regards,
>>
>> Ashesh Vashi
>> EnterpriseDB INDIA: Enterprise PostgreSQL Company<http://www.enterprisedb.com>
>>
>>
>>
>> *http://www.linkedin.com/in/asheshvashi*<http://www.linkedin.com/in/asheshvashi>
>>
>>
>>
>> On Thu, Dec 1, 2011 at 6:56 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>>> The contents of the extensions are in public, but the comments are part
>>> of the extension itself (ie. the "package"), so don't they also live
>>> outside of any schema like the extension itself?
>>>
>>>
>>> On Thu, Dec 1, 2011 at 1:23 PM, Ashesh Vashi <
>>> ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
>>>
>>>> Aren't they installed in that schema?
>>>> --
>>>>
>>>> Thanks & Regards,
>>>>
>>>> Ashesh Vashi
>>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company<http://www.enterprisedb.com>
>>>>
>>>>
>>>>
>>>> *http://www.linkedin.com/in/asheshvashi*<http://www.linkedin.com/in/asheshvashi>
>>>>
>>>>
>>>>
>>>> On Thu, Dec 1, 2011 at 6:52 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>>>
>>>>>
>>>>>
>>>>> On Thu, Dec 1, 2011 at 12:57 PM, Ashesh Vashi <
>>>>> ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
>>>>>
>>>>>> On Thu, Dec 1, 2011 at 4:43 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>>>>>
>>>>>>> Hi,
>>>>>>>
>>>>>>> On Wed, Nov 30, 2011 at 8:31 PM, Ashesh Vashi
>>>>>>> <ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
>>>>>>> > Hi Dave,
>>>>>>> >
>>>>>>> > Please find the patch for the supporting the EXTENSION keyword in
>>>>>>> the
>>>>>>> > frmRestore dialog.
>>>>>>> >
>>>>>>> > Description:
>>>>>>> > ============
>>>>>>> > If User perform back up database with supported format like custom
>>>>>>> and tar,
>>>>>>> > it taken successfully. While browse the particular file on Restore
>>>>>>> database
>>>>>>> > and Click on display object, an error occurred while schema node
>>>>>>> is not
>>>>>>> > found.
>>>>>>>
>>>>>>> Something's not quite right - it's showing my table under an
>>>>>>> extension node!
>>>>>>>
>>>>>>
>>>>>> Yeah - that was a typical "Copy/Paste" error.
>>>>>> PFA - the updated patch.
>>>>>>
>>>>>>
>>>>> Slightly better. Now the extension comments are shown under the public
>>>>> schema.
>>>>>
>>>>>
>>>>> --
>>>>> Dave Page
>>>>> Blog: http://pgsnake.blogspot.com
>>>>> Twitter: @pgsnake
>>>>>
>>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>>> The Enterprise PostgreSQL Company
>>>>>
>>>>>
>>>>
>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>>
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>

Attachment Content-Type Size
FB20196_v3.patch application/octet-stream 3.7 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2011-12-02 10:37:49 pgAdmin III commit: Update docs for PG 8.2.23.
Previous Message Guillaume Lelarge 2011-12-01 22:05:18 Re: New minor release?