| From: | Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com> |
|---|---|
| To: | Dave Page <dave(dot)page(at)enterprisedb(dot)com> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | [PATCH] pgAgent segfault |
| Date: | 2018-06-11 04:25:06 |
| Message-ID: | CAG7mmoy7ruK=HZGOt5GTFsuSF5e4+zHnagU0hJfuMUhqjZs=mw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi Dave,
While debugging the issue
<https://www.postgresql.org/message-id/CAG7mmoxXB0DsLZyvZ7qevoG17x7bJyw2DWdd0SXEgFg2Uc993A%40mail.gmail.com>
reported by Rob, I found one segfault.
Please find the attached patch to find that fix along with another one.
1. Connection object was being accessed, which was already released.
2. Changed the logic for checking the connection object existence.
We're using "if (!ms_primaryCon)", which should convert the logic as
boolean operator explicitly, which we defined for the 'DBconn' class.
I suspect some compilers (specifically windows one) may not behave that
way, and instead of using the boolean operator, it checks for the pointer
is NULL or not.
--
Thanks & Regards,
Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
<http://www.enterprisedb.com>
*http://www.linkedin.com/in/asheshvashi*
<http://www.linkedin.com/in/asheshvashi>
| Attachment | Content-Type | Size |
|---|---|---|
| pgagent_segfault.patch | application/octet-stream | 865 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ashesh Vashi | 2018-06-11 04:28:17 | Re: PGAgent 4.0 error feedback |
| Previous Message | Ashesh Vashi | 2018-06-11 03:43:01 | Re: PGAgent 4.0 error feedback |