Re: PATCH: Table header size

On Mon, Feb 11, 2019 at 12:18 PM Chethana Kumar <
chethana(dot)kumar(at)enterprisedb(dot)com> wrote:

> Ashesh,
>
> On Mon, Feb 11, 2019 at 11:51 AM Ashesh Vashi <
> ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>> On Fri, Feb 8, 2019 at 7:28 PM Chethana Kumar <
>> chethana(dot)kumar(at)enterprisedb(dot)com> wrote:
>>
>>> Yes Dave, I am agree with you!
>>>
>>> But some default padding is required for left and right.
>>> For example- 8px 5px 8px 5px; (top, right, bottom, left)
>>> This combination will get you similar look and feel of output same as my
>>> reference design.
>>>
>>> [image: current_rev_2x.png]
>>>
>> @Chethana Kumar <chethana(dot)kumar(at)enterprisedb(dot)com> - he is not saying,
>> we should not have left, and right padding.
>> He means to say - only set the top, and bottom padding, and that way - we
>> would always have consistent left, and right padding (which will be
>> inherited from the bootstrap CSS).
>>
>
> Yes I did get that point but what I was trying to say that the* left and
> right padding should have certain proportionate values with the top and
> bottom* then only it looks visually appealing.
>
> Ultimately, The padding should be given by a calculative way but not a
> random way. Hope you got my concern here.
>
It's not some random value.
We can't have left/right padding different for headers, and body cell.
It must be matching.

So - the option we have is to increase the left/right padding for body
cells (td) as well.

-- Thanks, Ashesh

> ---
> Chethana kumar
>
>
>>
>> @Dave - please find the updated patch.
>>
>> -- Thanks, Ashesh
>>
>>
>>>
>>> ---
>>> Chethana kumar
>>>
>>> On Fri, Feb 8, 2019 at 2:56 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>>
>>>> Hi
>>>>
>>>> Can we adjust the top/bottom padding, but leave the left/right? By
>>>> modifying the left/right padding, we cause the data to become offset with
>>>> the header.
>>>>
>>>> Otherwise I'm cool with the change.
>>>>
>>>> On Fri, Feb 8, 2019 at 6:40 AM Chethana Kumar <
>>>> chethana(dot)kumar(at)enterprisedb(dot)com> wrote:
>>>>
>>>>> Hi Dave/Team,
>>>>>
>>>>> Just explain it -
>>>>>
>>>>> *Change - *Increased the padding for '*th*' (table header)
>>>>>
>>>>> *Reason - *The table header is *not getting highlighted enough* thus
>>>>> the *sense of hierarchy and visual difference between 'th' and 'td'
>>>>> is not strong enough*
>>>>>
>>>>> *Case study -*
>>>>> If you see the existing version of table everything looks flat in
>>>>> terms of hierarchy due to 'white background' for both *'th'* and *'td'
>>>>> *except the header texts are in bold.
>>>>> I would recommend you to see it in the actual application for better
>>>>> clarity of the issue.
>>>>>
>>>>> *Conclusion -*
>>>>> Padding does that required *differentiation part* in order to
>>>>> highlight/achieve the hierarchy.
>>>>>
>>>>> Attaching the reference design too and going further I am aiming to
>>>>> reach this level of look and feel with our application.
>>>>> I really feel that "a good amount of breathing space sets the user's
>>>>> mind calm and focused towards reading the data" :)
>>>>>
>>>>>
>>>>>
>>>>> ---
>>>>> Chethana kumar
>>>>>
>>>>>
>>>>> On Fri, Feb 8, 2019 at 10:34 AM Ashesh Vashi <
>>>>> ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
>>>>>
>>>>>> Hi Dave/Team,
>>>>>>
>>>>>> As my offline conversation with Chethana, we need better look 'n'
>>>>>> feel for the table header row.
>>>>>> And - as per his proposal I've modified the table header row to look
>>>>>> different from rest of the rows.
>>>>>>
>>>>>> Please find the attached patch for the same.
>>>>>>
>>>>>> Let me share the screen shot for the now, and proposed change.
>>>>>> Now:
>>>>>> [image: Screen Shot 2019-02-08 at 10.31.35 AM.png]
>>>>>>
>>>>>> Proposed:
>>>>>> [image: Screen Shot 2019-02-08 at 10.29.20 AM.png]
>>>>>>
>>>>>> Please let me know your thoughts.
>>>>>>
>>>>>> --
>>>>>>
>>>>>> Thanks & Regards,
>>>>>>
>>>>>> Ashesh Vashi
>>>>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>>>>>> <http://www.enterprisedb.com>
>>>>>>
>>>>>>
>>>>>> *http://www.linkedin.com/in/asheshvashi*
>>>>>> <http://www.linkedin.com/in/asheshvashi>
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Chethana Kumar
>>>>> Principal UI/UX Designer
>>>>> EnterpriseDB Corporation
>>>>>
>>>>>
>>>>> The Postgres Database Company
>>>>>
>>>>> P: +91 86981 57146
>>>>> www.enterprisedb.com
>>>>>
>>>>
>>>>
>>>> --
>>>> Dave Page
>>>> Blog: http://pgsnake.blogspot.com
>>>> Twitter: @pgsnake
>>>>
>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>> The Enterprise PostgreSQL Company
>>>>
>>>
>>>
>>> --
>>> Chethana Kumar
>>> Principal UI/UX Designer
>>> EnterpriseDB Corporation
>>>
>>>
>>> The Postgres Database Company
>>>
>>> P: +91 86981 57146
>>> www.enterprisedb.com
>>>
>>
>
> --
> Chethana Kumar
> Principal UI/UX Designer
> EnterpriseDB Corporation
>
>
> The Postgres Database Company
>
> P: +91 86981 57146
> www.enterprisedb.com
>