Re: PG19: flat-copied RelOptInfos share extension_state with the original rel

From: Sho Ito <i(dot)sho(dot)0628(at)gmail(dot)com>
To: Shubhankar Anand Kulkarni <shubhankar(dot)ak(at)zohocorp(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, robertmhaas <robertmhaas(at)gmail(dot)com>, guofenglinux <guofenglinux(at)gmail(dot)com>
Subject: Re: PG19: flat-copied RelOptInfos share extension_state with the original rel
Date: 2026-10-14 03:32:06
Message-ID: CAG7L5+7NOvtAGFogDrYvwnTvd13YdCKuQCRHpwDEOjA4HSzbxQ@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Oct 13, 2026 at 6:37 AM Shubhankar Anand Kulkarni <
shubhankar(dot)ak(at)zohocorp(dot)com> wrote:

> Since this touches both the extension-state API and
> eager aggregation, are you OK with resetting the fields at each copy
> site, or would you rather have a shared helper that does the flat copy
> and the resets in one place?
>

I'm okay with the per-site resets for this fix, alongside the existing
duplicated path resets.

> Also can we turn the reproducer into a src/test/modules test if you'd like
> regression coverage for it?
>

Yes, I believe regression coverage under src/test/modules would be useful.

I'll hold off on updating the status until I've reviewed the
revised patch and run the new test.

Thanks,
Sho Ito

--
=======================================
*Sho Ito (Sean)*

E-mail: i(dot)sho(dot)0628(at)gmail(dot)com
LinkedIn: *https://www.linkedin.com/in/sho-ito-0628/
<https://www.linkedin.com/in/sho-ito-0628/>*
GitHub: https://github.com/sean0628/
=======================================

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message shihao zhong 2026-10-14 03:33:18 Re: [PG19] psql backslash commands fail with translated messages and a non UTF-8 client encoding
Previous Message Bharath Rupireddy 2026-10-14 03:30:00 Parallel vacuum: avoid dangling shared memory pointers