Re: [DEPARSE] Pretty-printed sublink test expressions lose needed parentheses

From: Sho Ito <i(dot)sho(dot)0628(at)gmail(dot)com>
To: assam258(at)gmail(dot)com
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [DEPARSE] Pretty-printed sublink test expressions lose needed parentheses
Date: 2026-10-18 09:48:03
Message-ID: CAG7L5+78_sZ1U0-GApToZyAquPCke14UDx9h4YLJe4S1-J+aFw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Oct 13, 2026 at 2:04 PM Henson Choi <assam258(at)gmail(dot)com> wrote:

>
> Whatever one thinks of that, deparse has to print text that
> our own grammar reads back as the same expression, so it has
> to follow the precedence in gram.y, even if gram.y were wrong.
>

Hi Henson,

I reviewed both v1 patches on master with assertions enabled. The core
regression results match the expected output with 0001 alone and with both
patches applied. The view recreation tests reproduce the changed results
and errors before the fix; after the fix, the recreated views return the
same results as the originals.

I found no blocking issue in the changes.

Thanks,
Sho Ito

--
=======================================
*Sho Ito (Sean)*

E-mail: i(dot)sho(dot)0628(at)gmail(dot)com
LinkedIn: *https://www.linkedin.com/in/sho-ito-0628/
<https://www.linkedin.com/in/sho-ito-0628/>*
GitHub: https://github.com/sean0628/
=======================================

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Rui Zhao 2026-10-18 10:01:05 Re: psql single-step mode woes
Previous Message Muzzammil Sarwar 2026-10-18 09:10:41 [PATCH] Fix plpgsql's R/W optimization for simple expressions run via SPI