| From: | Sho Ito <i(dot)sho(dot)0628(at)gmail(dot)com> |
|---|---|
| To: | assam258(at)gmail(dot)com |
| Cc: | pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH v1] Preserve implicit composite casts in ROW deparsing |
| Date: | 2026-11-20 04:41:09 |
| Message-ID: | CAG7L5+69JicGbnq+tmKY4WiQ-zL5e-Hd7mcH8c8yQLaXhooBfA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Henson,
Thanks for the review and for testing the patch.
> The strongest case is VARIADIC, where a dump from master does not restore
> even without
> adding an overload later:
>
Attached v2 adds the `VARIADIC` case, including view recreation with
pretty-printing both enabled and disabled, and the column-default test
to cover `showimplicit = false`. The default still deparses as
`ROW(1, 2)`. The implementation is unchanged from v1.
> Agreed. I tried 15-19: there is only an easily fixed conflict, and no
> code changes are needed:
>
As you noted, 19 takes the patch unchanged; on 15-18 I omitted only the
`updatable_views.out` hunk.
The attachments are alternatives: the main patch is for master and 19;
the `nocfbot-` patch is for 15-18. They should be applied separately,
not as a series.
I agree about keeping the `EXPLAIN` changes. Thanks also for clarifying
the overlap with #7452 [1].
Regards,
Sho
[1] https://commitfest.postgresql.org/patch/7452/
--
=======================================
*Sho Ito (Sean)*
E-mail: i(dot)sho(dot)0628(at)gmail(dot)com
LinkedIn: *https://www.linkedin.com/in/sho-ito-0628/
<https://www.linkedin.com/in/sho-ito-0628/>*
GitHub: https://github.com/sean0628/
=======================================
| Attachment | Content-Type | Size |
|---|---|---|
| nocfbot-v2-0001-PG15_PG18-Preserve-implicit-composite-casts-in-ROW-deparse.patch | application/octet-stream | 13.4 KB |
| v2-0001-Preserve-implicit-composite-casts-in-ROW-deparse.patch | application/octet-stream | 14.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2026-11-20 04:47:17 | Re: Index drops during phase 1 of REINDEX CONCURRENTLY |
| Previous Message | Bertrand Drouvot | 2026-11-20 04:32:25 | Re: Add a hook for handling logical decoding messages on subscribers. |