| From: | Sho Ito <i(dot)sho(dot)0628(at)gmail(dot)com> |
|---|---|
| To: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
| Cc: | assam258(at)gmail(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: [PATCH v1] Preserve implicit composite casts in ROW deparsing |
| Date: | 2026-11-21 04:38:35 |
| Message-ID: | CAG7L5+5vR2OLuW95HHybDJw4x1FwmDA_Fn_MeyukKW-0R3Uzjg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Horiguchi san,
> However, I think the comment might be more useful if it focused on
> explaining why RECORDOID can be excluded even when showimplicit is
> true.
>
Thanks for reviewing. Attached v3 revises the comment to explain that
a bare `ROW()` already has type `RECORD`, so omitting an implicit
cast to `RECORD` does not affect overload resolution on reparse.
There are no code or test changes from v2. I also added author and
reviewer credits and the discussion link to the commit messages.
The main attachment is for master and 19; the `nocfbot-` attachment
is the alternative for 15-18.
Thanks,
Sho
--
=======================================
*Sho Ito (Sean)*
E-mail: i(dot)sho(dot)0628(at)gmail(dot)com
LinkedIn: *https://www.linkedin.com/in/sho-ito-0628/
<https://www.linkedin.com/in/sho-ito-0628/>*
GitHub: https://github.com/sean0628/
=======================================
| Attachment | Content-Type | Size |
|---|---|---|
| nocfbot-v3-0001-PG15_PG18-Preserve-implicit-composite-casts-in-ROW-deparse.patch | application/octet-stream | 13.6 KB |
| v3-0001-Preserve-implicit-composite-casts-in-ROW-deparse.patch | application/octet-stream | 15.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Previous Message | Scott Ray | 2026-11-21 04:01:21 | Re: pg_xmin_horizon: a system view of everything pinning the xmin horizon |