Re: [PATCH] psql: Fix REPACK index completion after a column list

From: Sho Ito <i(dot)sho(dot)0628(at)gmail(dot)com>
To: Ishjaap Singh <ishjaap(dot)singh07(at)gmail(dot)com>
Cc: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [PATCH] psql: Fix REPACK index completion after a column list
Date: 2026-11-14 16:52:16
Message-ID: CAG7L5+4f_BDMiXZ0G3+pB3qLdPu2McCh-=+TrnaZC+2SDMuUYA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Ishjaap,

Thanks for the detailed review and testing on both branches.

> pgperltidy wants two lines in the new tests rewrapped.

I've applied the two `pgperltidy` formatting changes in the attached v4;
the code patch is unchanged. All four psql TAP suites pass on master
with assertions enabled.

> The conflicts are in adjacent completion rules and the test insertion
point. I'm happy to
> rebase whichever one lands second.

Thanks for offering to rebase #7574 if needed. I'm also happy to rebase
this series if #7574 lands first.

Thanks,
Sho

--
=======================================
*Sho Ito (Sean)*

E-mail: i(dot)sho(dot)0628(at)gmail(dot)com
LinkedIn: *https://www.linkedin.com/in/sho-ito-0628/
<https://www.linkedin.com/in/sho-ito-0628/>*
GitHub: https://github.com/sean0628/
=======================================

Attachment Content-Type Size
v4-0001-psql-Fix-REPACK-tab-completion-around-USING-INDEX.patch application/octet-stream 2.4 KB
v4-0002-psql-Add-regression-tests-for-REPACK-tab-completi.patch application/octet-stream 2.8 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Previous Message Peter Geoghegan 2026-11-14 16:27:13 Re: auto_explain crashes on EXPLAIN (BUFFERS) of an index scan (19, master)