Re: Additional size of hash table is alway zero for hash aggregates

From: Pengzhou Tang <ptang(at)pivotal(dot)io>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Jeff Davis <pgsql(at)j-davis(dot)com>
Subject: Re: Additional size of hash table is alway zero for hash aggregates
Date: 2020-03-14 00:50:55
Message-ID: CAG4reAQaiwoCr7QFPwHxR3CbQaLT_71cLP6kpF+ESc4GT4WWfA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

>
> On 2020-03-12 16:35:15 +0800, Pengzhou Tang wrote:
> > When reading the grouping sets codes, I find that the additional size of
> > the hash table for hash aggregates is always zero, this seems to be
> > incorrect to me, attached a patch to fix it, please help to check.
>
> Indeed, that's incorrect. Causes the number of buckets for the hashtable
> to be set higher - the size is just used for that. I'm a bit wary of
> changing this in the stable branches - could cause performance changes?
>
>
thanks for confirming this.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Pengzhou Tang 2020-03-14 00:51:14 Re: Additional size of hash table is alway zero for hash aggregates
Previous Message James Coleman 2020-03-14 00:23:07 Re: [PATCH] Incremental sort (was: PoC: Partial sort)