| From: | Maaz Syed Adeeb <maaz(dot)adeeb(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-bugs(at)lists(dot)postgresql(dot)org, matthew(dot)ripley28(at)gmail(dot)com |
| Subject: | Re: CREATE INDEX with an expression in an INCLUDE column fails with XX000 "unrecognized node type" instead of 0A000 on master |
| Date: | 2026-07-15 18:57:27 |
| Message-ID: | CAG+FJqN84B4KjmMp2oR2wSJUiEbgG1SV78wncUmi2Cz1qvDUOA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
I'm happy to add a test case to the patch and resubmit it. It'd be my
first contribution to PG, so happy to get my feet wet with setting up
the env, running tests, contribution process, etc. Let me know if
that'd be OK.
Regards,
Maaz Syed Adeeb
On Wed, Jul 15, 2026 at 11:29 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Maaz Syed Adeeb <maaz(dot)adeeb(at)gmail(dot)com> writes:
> > On current master, creating an index with an expression in an INCLUDE
> > (non-key) column fails with an internal error ("unrecognized node
> > type", SQLSTATE XX000) instead of the user-facing
> > FEATURE_NOT_SUPPORTED (0A000) "expressions are not supported in
> > included columns". The statement is still correctly rejected, but with
> > the wrong error class and a message.
>
> Thanks for the report! This is evidently happening because we have
> not applied parse transformation to the included columns. I think
> that the most appropriate way to fix it is to start doing so, even
> though the feature will be rejected later. More or less as attached
> (but we ought to add a test case too).
>
> regards, tom lane
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2026-07-15 19:12:45 | Re: CREATE INDEX with an expression in an INCLUDE column fails with XX000 "unrecognized node type" instead of 0A000 on master |
| Previous Message | Tom Lane | 2026-07-15 18:29:04 | Re: CREATE INDEX with an expression in an INCLUDE column fails with XX000 "unrecognized node type" instead of 0A000 on master |