| From: | Zhijie Hou <houzhijie22(at)gmail(dot)com> |
|---|---|
| To: | shveta malik <shveta(dot)malik(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, shihao zhong <zhong950419(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Manu <manuelreyesbravo(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, shveta malik <shvetamalik(at)gmail(dot)com> |
| Subject: | Re: [PG19] Promotion hangs behind a backend blocked on a stuck client |
| Date: | 2026-10-22 07:13:46 |
| Message-ID: | CAFvd2n_Babe_p-7GRzNHXJKfxnBMbsHeK0=pHgfpgy2knx0jyg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On Thu, Oct 22, 2026 at 2:29 PM shveta malik <shveta(dot)malik(at)gmail(dot)com> wrote:
>
> On Thu, Oct 22, 2026 at 11:45 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> >
> > On Thu, Oct 22, 2026 at 10:42 AM Hayato Kuroda (Fujitsu)
> > <kuroda(dot)hayato(at)fujitsu(dot)com> wrote:
> > >
> > > Hi Amit, Shveta,
> > >
> > > > After a configuration reload, an existing session picks up the new
> > > > value when its client sends the next query.
> > >
> > > IIUC the description is correct: a backend process reloads the configuration in
> > > the main loop, and assign hook can be called there. But yours are also OK if you
> > > think it's too detail.
> > >
> >
> > I am also okay with both but would prefer mine as that appears clear
> > and succinct.
>
> Okay, PFA the patch with comments addressed
The doc patch looks good to me. One minor nit:
"valid (not invalidated)" feels a bit redundant, as "valid" alone seems
sufficient.
Best Regards,
Zhijie Hou
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Zhijie Hou | 2026-10-22 07:16:01 | Re: [PG19] Promotion hangs behind a backend blocked on a stuck client |
| Previous Message | Dean Rasheed | 2026-10-22 07:13:40 | Re: [DEPARSE] EXPLAIN prints another ModifyTable's RETURNING aliases in a SubPlan |