| From: | Zhijie Hou <houzhijie22(at)gmail(dot)com> |
|---|---|
| To: | shveta malik <shveta(dot)malik(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Dilip Kumar <DilipBalaut(at)gmail(dot)com>, Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, saurabh singh <saurabh(dot)singh214(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Proposal: Conflict log history table for Logical Replication |
| Date: | 2026-10-14 02:13:14 |
| Message-ID: | CAFvd2n8Vra0ctRxWVG21FZQeGnZ3Pb=jgk0BCrGobivWOqQbOw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On Tue, Oct 13, 2026 at 6:29 PM shveta malik <shveta(dot)malik(at)gmail(dot)com> wrote:
>
> I analyzed that 'intervalstyle' could also cause correctness issue
> when reading the values. Attached the testcase with results before and
> after fix in it.
>
> The fix would be similar to DateStyle fix in build_index_key_json():
>
> + (void) set_config_option("intervalstyle", "postgres",
> + PGC_USERSET, PGC_S_SESSION,
> + GUC_ACTION_SAVE, true, 0, false);
>
> Will analyze 'extra_float_digits' next.
Thanks!
I also re-confirmed locally that all the parameters you reported (e.g.
DateStyle, IntervalStyle, extra_float_digits) have similar issues, and setting
the GUCs manually when building the CLT row is an appropriate way to fix this.
Please see the attachment for a TAP test on top of v81 that tries to reproduce
all of them. And if we plan to fix this along with the main patch, I think it
would be worth keeping a simple test case like the attached one.
Best Regards,
Zhijie Hou
| Attachment | Content-Type | Size |
|---|---|---|
| nocfbot_vTopup_81-0001-Test-for-Datestyle-IntervalStyle-extra_flo.patch | application/octet-stream | 5.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2026-10-14 02:17:00 | Re: Add missing FreeDir in CheckTablespaceDirectory |
| Previous Message | Tatsuo Ishii | 2026-10-14 01:50:43 | Re: Row pattern recognition |