Re: [PG19] Sequence sync stops when the subscription owner can't SET ROLE to a sequence owner

From: Zhijie Hou <houzhijie22(at)gmail(dot)com>
To: "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>
Cc: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, vignesh C <vignesh21(at)gmail(dot)com>
Subject: Re: [PG19] Sequence sync stops when the subscription owner can't SET ROLE to a sequence owner
Date: 2026-10-20 13:59:04
Message-ID: CAFvd2n8GAqsb+tOHQ_=CMdPpq1XDXHvaqD=HH_U=TJktVSMVVQ@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On Tue, Oct 20, 2026 at 2:21 PM Hayato Kuroda (Fujitsu)
<kuroda(dot)hayato(at)fujitsu(dot)com> wrote:
> > I agree that we cannot catch all possible errors. After thinking about this
> > more, there are other errors—such as deadlock timeout or lock timeout—that
> > cannot easily be pre-checked, so adding an error context looks like a good
> > approach to me. Attached is a patch that adds the error context as
> > suggested.
>
> Thanks for the patch. I initially felt that setting/reseting the error context
> can be in the copy_sequence(), but yours seem to slightly better.
> get_and_validate_seq_info() may report another error.
>
> One comment for the test: below lines may not be needed, because REFRESH SEQUENCES
> does not require apply workers, and the launcher eventually starts workers with
> the appropriate owner. Doesn't upcoming wait_for_log() enough?

Agreed. Here is the new version that removes this.

Best Regards,
Zhijie Hou

Attachment Content-Type Size
v3-0001-Add-error-context-for-sequence-synchronization.patch application/octet-stream 5.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Harrison Booth 2026-10-20 14:19:14 Re: meson vs. llvm bitcode files
Previous Message harrisontbooth 2026-10-20 13:42:28 Re: [PATCH v2] meson: Support ECPG tests in runnable cross builds