Re: [PATCH] Improve autocompletion for SELECT statements

From: Wander Winkelhorst <w(dot)winkelhorst(at)gmail(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: Guillaume Lelarge <guillaume(at)lelarge(dot)info>, "pgadmin-hackers(at)postgresql(dot)org" <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Improve autocompletion for SELECT statements
Date: 2011-11-14 20:15:31
Message-ID: CAFv2D8vDQe_QUik15-uLT8F+DC=5yz793PNNEgT8D_xziHNifw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Mon, Nov 14, 2011 at 10:16 AM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>
> FYI, I just took a look at the patch and it does touch
> tab-complete.inc - it certainly should *not* do that, as
> tab-complete.inc is generated with tabcomplete.pl from the upstream
> tab-complete.c. Any changes made to it are likely to be lost the next
> time it's updated. If that file must be changed, then it should be
> done by tab-complete.pl, though frankly it would be better to push the
> changes into psql first.
>

Could you please tell me how I'm supposed to use tabcomplete.pl, and where
I can get the correct version of tab-complete.c?

On Sun, Nov 13, 2011 at 11:06 PM, Guillaume Lelarge <guillaume(at)lelarge(dot)info>
wrote:
> They all are part of fbb_categories. Unfortunately, that doesn't explain
> the comma

That's because the comma gets recognized as a table alias :)
I'm going to take a look at these issues soon.

Regards,
Wander WInkelhorst.

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Guillaume Lelarge 2011-11-14 22:23:44 Re: Compilation on Debian SID
Previous Message Dave Page 2011-11-14 09:16:52 Re: [PATCH] Improve autocompletion for SELECT statements