Re: Git revision in tarballs

From: Josef Šimánek <josef(dot)simanek(at)gmail(dot)com>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Git revision in tarballs
Date: 2021-07-15 11:40:31
Message-ID: CAFp7QwpC_3=OntkrbsgG+7mcfhaUBDFTyUYD49FXN5bPf3xTZw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

čt 15. 7. 2021 v 10:33 odesílatel Magnus Hagander <magnus(at)hagander(dot)net> napsal:
>
> I think it'd be useful to be able to identify exactly which git commit
> was used to produce a tarball. This would be especially useful when
> downloading snapshot tarballs where that's not entirely clear, but can
> also be used to verify that the release tarballs matches what's
> expected (in the extremely rare case that a tarball is rewrapped for
> example).
>
> What do people think of the attached?

The only problem I do see is adding "git" as a new dependency. That
can potentially cause troubles.

For the file name, I have seen GIT_VERSION or REVISION file names used
before in another projects. Using ".gitrevision" doesn't make sense to
me since it will be hidden on Unix by default and I'm not sure that is
intended.

> --
> Magnus Hagander
> Me: https://www.hagander.net/
> Work: https://www.redpill-linpro.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dave Cramer 2021-07-15 11:40:54 Re: pg_upgrade does not upgrade pg_stat_statements properly
Previous Message Aleksander Alekseev 2021-07-15 11:38:32 Re: Signed vs Unsigned (take 2) (src/backend/storage/ipc/procarray.c)