| From: | Josef Šimánek <josef(dot)simanek(at)gmail(dot)com> |
|---|---|
| To: | Philip Alger <paalger0(at)gmail(dot)com> |
| Cc: | Josef Šimánek <retro(at)ballgag(dot)cz>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, jian he <jian(dot)universality(at)gmail(dot)com>, Jim Jones <jim(dot)jones(at)uni-muenster(dot)de>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Cary Huang <cary(dot)huang(at)highgo(dot)ca>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Add pg_get_trigger_ddl() to retrieve the CREATE TRIGGER statement |
| Date: | 2025-11-03 01:31:52 |
| Message-ID: | CAFp7Qwo=Gmz11QRu+x_9wkPVCfwR_btY0XYnH1LE+cZzjUDP0A@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
po 3. 11. 2025 v 2:22 odesílatel Philip Alger <paalger0(at)gmail(dot)com> napsal:
>
> Hello,
>
>
>>
>> > I think it’s better to pfree(res).
>>
>> Would you mind to share why pfree is needed? I tried to trace this
>> with Valgrind, but even pfree(res) was present or not, there was no
>> leak detected and both compiles without additional warnings. Wouldn't
>> be res "trashed" at the end of the function (after next line) anyway?
>
>
> The wrapper function string_to_text, which is a wrapper for cstring_to_text, includes pfree.
>
> see ruleutils.c
>
> static text *
> string_to_text(char *str)
> {
> text *result;
>
> result = cstring_to_text(str);
> pfree(str);
> return result;
> }
Indeed, IMHO pfree is not needed and the current patch is good as is.
>
> --
> Best,
> Phil Alger
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2025-11-03 02:09:43 | Re: meson's in-tree libpq header search order vs -Dextra_include_dirs |
| Previous Message | Josef Šimánek | 2025-11-03 01:30:55 | Re: [PATCH] Add pg_get_trigger_ddl() to retrieve the CREATE TRIGGER statement |