| From: | Josef Šimánek <josef(dot)simanek(at)gmail(dot)com> |
|---|---|
| To: | Philip Alger <paalger0(at)gmail(dot)com> |
| Cc: | Josef Šimánek <retro(at)ballgag(dot)cz>, jian he <jian(dot)universality(at)gmail(dot)com>, Jim Jones <jim(dot)jones(at)uni-muenster(dot)de>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Cary Huang <cary(dot)huang(at)highgo(dot)ca>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Add pg_get_trigger_ddl() to retrieve the CREATE TRIGGER statement |
| Date: | 2025-11-03 01:30:55 |
| Message-ID: | CAFp7Qwo1f1SZQ00gKVa_15r6vvo91BdjCvoAa=AvjK7qMTGAKQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
po 3. 11. 2025 v 2:18 odesílatel Philip Alger <paalger0(at)gmail(dot)com> napsal:
>
> Hi Josef,
>
>> Would it make sense to rename trigger related variables to "trig"
>> prefix instead of "trg" as is done in other functions in the same file
>> (for example in function pg_get_triggerdef)?
>
>
> Not sure it would be the same as triggerdef uses trig, while triggerdef_worker uses a mix of trig and tg in the same function. It would be another patch, I believe, to and correct a prefix, then you'd have to normalize all the other functions within the same file.
If you mind updating the current patch to not add a third version (or
spread the problem), I'm happy to provide a later separate patch to
unify terminology in that file for triggers.
> --
> Best,
> Phil Alger
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Josef Šimánek | 2025-11-03 01:31:52 | Re: [PATCH] Add pg_get_trigger_ddl() to retrieve the CREATE TRIGGER statement |
| Previous Message | Philip Alger | 2025-11-03 01:22:26 | Re: [PATCH] Add pg_get_trigger_ddl() to retrieve the CREATE TRIGGER statement |