Re: Patch: add --if-exists to pg_recvlogical

From: Rosser Schwarz <rosser(dot)schwarz(at)gmail(dot)com>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>
Subject: Re: Patch: add --if-exists to pg_recvlogical
Date: 2017-09-17 22:21:22
Message-ID: CAFnxYwiOqt_5ke3y1RCEWxchQS_kW8Nd3XtSMJjOSi6ZinR5NA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On Fri, Sep 1, 2017 at 10:22 AM, Peter Eisentraut <
peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
> I understand the --drop-slot part. But I don't understand what it means
> to ignore a missing replication slot when running --start.

I'm not sure I do either, honestly. I followed the Principle of Least
Surprise in making it a no-op when those switches are used and the slot
doesn't exist, over "no one will ever do that". Because someone will.

I'm happy to hear suggestions on what to do in that case beyond exit
cleanly.

> The same option should be added to pg_receivewal as well.

Done.

On Fri, Sep 8, 2017 at 21:06 Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>
wrote:
> Also "<option>--start<option>" breaks the documentation build
> (missing slash on the closing tag).

Fixed, thanks.

Please see revised patch, attached, addressing both comments.

rls

--
:wq

Attachment Content-Type Size
pg_recvlogical--if-exists-v2.patch application/octet-stream 8.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2017-09-17 22:52:05 Re: [PATCH] Generic type subscripting
Previous Message Alvaro Herrera 2017-09-17 21:38:35 Re: SQL/JSON in PostgreSQL