| From: | 高增琦 <pgf00a(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Steven Niu <niushiji(at)gmail(dot)com>, John Naylor <johncnaylorls(at)gmail(dot)com>, "tmunro(at)postgresql(dot)org" <tmunro(at)postgresql(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Compile error on the aarch64 platform: Missing asm/hwcap.h |
| Date: | 2025-11-18 02:54:31 |
| Message-ID: | CAFmBtr2Xu_R32RsmDOcTrN+Y6PJFROpYsQEi5ZA8XYNz56HwEw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Thanks for the quick fix.
There's another one (the last one) in the previous email that needs fixing:
HWCAP_SVE for pg_popcount_aarch64.c
😅
Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> 于2025年11月18日周二 04:31写道：
> I wrote:
> > ... I'm inclined to think
> > it's better to do something like
>
> > +#if defined(__linux__) && (defined(__aarch64__) ? !defined(HWCAP_CRC32)
> : !defined(HWCAP2_CRC32))
>
> > or perhaps that's too unreadable and we should break it out into
> > multiple #if's.
>
> I tried it as a nest of #ifdef's and decided that was none too
> readable either, so pushed it as above. Thanks for the report!
>
> regards, tom lane
>
--
GaoZengqi
pgf00a(at)gmail(dot)com
zengqigao(at)gmail(dot)com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | dinesh salve | 2025-11-18 03:25:39 | Re: explain plans for foreign servers |
| Previous Message | cca5507 | 2025-11-18 02:47:20 | Re: minor improvement in snapbuild: use existing interface and removefake code |