From: | 高增琦 <pgf00a(at)gmail(dot)com> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Dropping a partitioned table takes too long |
Date: | 2017-04-28 10:12:15 |
Message-ID: | CAFmBtr1N3-SbepJbnGpaYp=jw-FvWMnYY7-bTtRgvjvbyB8YJA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
It seems that in 'load_relcache_init_file()', we forget to initialize
'rd_pdcxt' of relcache.
2017-04-27 0:33 GMT+08:00 Robert Haas <robertmhaas(at)gmail(dot)com>:
> On Wed, Apr 26, 2017 at 12:22 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> >> On Tue, Apr 25, 2017 at 10:05 PM, Amit Langote
> >> <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> wrote:
> >>> Your patch seems to be a much better solution to the problem, thanks.
> >
> >> Does anyone wish to object to this patch as untimely?
> >
> >> If not, I'll commit it.
> >
> > It's certainly not untimely to address such problems. What I'm wondering
> > is if we should commit both patches. Avoiding an unnecessary heap_open
> > is certainly a good thing, but it seems like the memory leak addressed
> > by the first patch might still be of concern in other scenarios.
>
> I will defer to you on that. If you think that patch is a good idea,
> please have at it.
>
> --
> Robert Haas
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
--
GaoZengqi
pgf00a(at)gmail(dot)com
zengqigao(at)gmail(dot)com
From | Date | Subject | |
---|---|---|---|
Next Message | Beena Emerson | 2017-04-28 11:23:23 | Re: Crash when partition column specified twice |
Previous Message | Konstantin Knizhnik | 2017-04-28 10:01:31 | Re: Cached plans and statement generalization |