Re: [PATCH] Fix conversion for Decimal arguments in plpython functions

From: Szymon Guz <mabewlun(at)gmail(dot)com>
To: Steve Singer <steve(at)ssinger(dot)info>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, Ronan Dunklau <rdunklau(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Fix conversion for Decimal arguments in plpython functions
Date: 2013-06-28 20:28:05
Message-ID: CAFjNrYvNuf0Bhqx8N0K_n+mFFR+FcPT-ZJwa+QXbRt5PmxKTPw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 28 June 2013 22:14, Steve Singer <steve(at)ssinger(dot)info> wrote:

>
> I think the value is more important than the name, I want to the tests to
> make sure that the conversion is actually converting properly. With your
> method of getting the class name without the module we can have both.
>
> The attached patch should print the value and the class name but not the
> module name.
>
> Steve
>

Hi Steve,
I agree, we can check both. This is quite a nice patch now, I've reviewed
it, all tests pass, works as expected. I think it is ready for committing.

thanks,
Szymon

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Claudio Freire 2013-06-28 20:29:18 Re: [PATCH] Fix conversion for Decimal arguments in plpython functions
Previous Message Dean Rasheed 2013-06-28 20:22:52 Re: FILTER for aggregates [was Re: Department of Redundancy Department: makeNode(FuncCall) division]