Re: ALTER TABLE parent SET WITHOUT OIDS and the oid column

From: Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: ALTER TABLE parent SET WITHOUT OIDS and the oid column
Date: 2017-01-05 03:56:11
Message-ID: CAFjFpRfjZXhGoQVHkUvq_2LeXqq7Jd1ygp4s+Z4yW7jZzAR81Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

>
>> The code updating attinhcount and then updating the catalogs is same
>> for user defined attributes and OID. Should we separate it out into a
>> function and use that function instead of duplicating the code?
>
> Didn't really seem worth the trouble ... maybe if it gets any longer
> it'd be appropriate to do that.

Ok.

>
> Pushed with those corrections and some further fooling with the test case.
>

Thanks.

--
Best Wishes,
Ashutosh Bapat
EnterpriseDB Corporation
The Postgres Database Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2017-01-05 04:03:31 Re: increasing the default WAL segment size
Previous Message Tsunakawa, Takayuki 2017-01-05 03:12:09 Re: Supporting huge pages on Windows