Re: Incorrect debug info printed in generate_partition_wise_join_paths

From: Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>
To: Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Incorrect debug info printed in generate_partition_wise_join_paths
Date: 2017-12-11 08:24:26
Message-ID: CAFjFpRf8Ea+g6RnUO27q4AxJ5PmNxTwKMKx7QYnWWoTG6zK63g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Yes, that's the correct fix. We should be printing debug information
about the child and not the parent. Sorry for that bug and thanks for
fixing it.

On Fri, Dec 8, 2017 at 3:22 PM, Etsuro Fujita
<fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> wrote:
> generate_partition_wise_join_paths prints debug info, if
> OPTIMIZER_DEBUG, using debug_print_rel at the end of each iteration for
> collecting non-dummy child-joins, but I noticed that we pass to that
> function the parent's RelOptInfo, not such a child-join's RelOptInfo. I
> don't think it's intentional, so here is a patch for fixing that.
>
> Best regards,
> Etsuro Fujita

--
Best Wishes,
Ashutosh Bapat
EnterpriseDB Corporation
The Postgres Database Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Ashutosh Bapat 2017-12-11 08:39:13 Re: Out of date comment in cached_plan_cost
Previous Message Anthony Bykov 2017-12-11 08:22:06 Re: Jsonb transform for pl/python