| From: | Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Rushabh Lathia <rushabh(dot)lathia(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Postgres_fdw join pushdown - wrong results with whole-row reference |
| Date: | 2016-06-28 12:20:50 |
| Message-ID: | CAFjFpRed=Y0DSOkdgKTTuoByW+u1-aXHzxYGqvXw9TEwt=V+nA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
>
> >
> > postgres_fdw resets the search path to pg_catalog while opening
> connection
> > to the server. The reason behind this is explained in deparse.c
> >
> > * We assume that the remote session's search_path is exactly
> "pg_catalog",
> > * and thus we need schema-qualify all and only names outside pg_catalog.
>
> Hmm. OK, should we revert the schema-qualification part of that
> commit, or just leave it alone?
>
>
If we leave that code as is, someone who wants to add similar code later
would get confused or will be tempted to create more instances of
schema-qualification. I think we should revert the schema qualification.
--
Best Wishes,
Ashutosh Bapat
EnterpriseDB Corporation
The Postgres Database Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2016-06-28 13:29:58 | Re: ERROR: ORDER/GROUP BY expression not found in targetlist |
| Previous Message | Amit Kapila | 2016-06-28 11:52:06 | Re: fixing subplan/subquery confusion |