| From: | Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com> |
|---|---|
| To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Unused member root in foreign_glob_cxt |
| Date: | 2017-01-12 12:19:13 |
| Message-ID: | CAFjFpReQEGFF81qA==Q8uwJWi9k4kxn5ezssqi-MVpJ3baNB5A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
The member root in foreign_glob_cxt isn't used anywhere by
postgres_fdw code. Without that member the code compiles and
regression passes. The member was added by d0d75c40. I looked at that
commit briefly but did not find any code using it there. So, possibly
it's unused since it was introduced. Should we drop that member?
PFA the patch to remove that member. If we decide to drop that member,
we can drop root argument to is_foreign_expr() and clean up some more
code. I volunteer to do that, if we agree.
--
Best Wishes,
Ashutosh Bapat
EnterpriseDB Corporation
The Postgres Database Company
| Attachment | Content-Type | Size |
|---|---|---|
| pgfdw_unused_root.patch | fcatjava/download | 664 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | tushar | 2017-01-12 12:27:21 | Re: Parallel bitmap heap scan |
| Previous Message | Dilip Kumar | 2017-01-12 12:17:30 | Re: Parallel bitmap heap scan |