Re: spelling of enable_partition_wise_join

From: Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: spelling of enable_partition_wise_join
Date: 2018-02-19 07:40:04
Message-ID: CAFjFpReQ9SPtmkzwX609O+iJ-L=39rWVj+ksMSxPwV_DvEJ-Jg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Feb 19, 2018 at 9:08 AM, Ashutosh Bapat
<ashutosh(dot)bapat(at)enterprisedb(dot)com> wrote:
>
> Thanks. There are functions like try_partition_wise_join(),
> generate_partition_wise_join_paths() which use partition_wise
> spelling. Should we update those as well?

I see that the commit already did that. Sorry. Although, I would have
liked comments to spell "partition-wise" instead of "partitionwise".
https://dictionary.cambridge.org/dictionary/english/wise
differentiates between "-wise" and "wise". The later is used when
indicating a direction and the first one indicates "relating to". I
think here we want the first one.

--
Best Wishes,
Ashutosh Bapat
EnterpriseDB Corporation
The Postgres Database Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Fabien COELHO 2018-02-19 07:43:52 Re: pgbench - allow to specify scale as a size
Previous Message Tsunakawa, Takayuki 2018-02-19 07:05:47 [doc fix] Correct calculation of vm.nr_hugepages