Re: Log LDAP "diagnostic messages"?

On Wed, Sep 13, 2017 at 6:58 AM, Thomas Munro
<thomas(dot)munro(at)enterprisedb(dot)com> wrote:
> On Tue, Sep 12, 2017 at 11:23 PM, Ashutosh Bapat
> <ashutosh(dot)bapat(at)enterprisedb(dot)com> wrote:
>> On Wed, Aug 16, 2017 at 11:13 AM, Ashutosh Bapat
>> <ashutosh(dot)bapat(at)enterprisedb(dot)com> wrote:
>>> On Wed, Aug 16, 2017 at 8:44 AM, Alvaro Herrera
>>> <alvherre(at)2ndquadrant(dot)com> wrote:
>>>> Christoph Berg wrote:
>>>>> "Diagnostic message" doesn't really mean anything, and printing
>>>>> "DETAIL: Diagnostic message: <something>" seems redundant to me. Maybe
>>>>> drop that prefix? It should be clear from the context that this is a
>>>>> message from the LDAP layer.
>>>>
>>>> I think making it visible that the message comes from LDAP (rather than
>>>> Postgres or anything else) is valuable. How about this?
>>>>
>>>> LOG: could not start LDAP TLS session: Protocol error
>>>> DETAIL: LDAP diagnostics: unsupported extended operation.
>>>>
>>> +1, pretty neat.
>
> Here is a new version adopting Alvaro's wording. I'll set this back
> to "Needs review" status.
>

Thanks for the updated patches.

Looks good to me. The patch applies cleanly on the latest HEAD,
compiles without any errors or warnings and make check passes. Marking
this as ready for committer.

--
Best Wishes,
Ashutosh Bapat
EnterpriseDB Corporation
The Postgres Database Company