| From: | Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com> |
|---|---|
| To: | Jeevan Chalke <jeevan(dot)chalke(at)enterprisedb(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Replacing lfirst() with lfirst_node() appropriately in planner.c |
| Date: | 2017-09-05 11:57:20 |
| Message-ID: | CAFjFpRe1RjcNoXhfD6jJw0mHbW4G64WSOu2CXE3O72ifog-Uww@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Sep 5, 2017 at 4:02 PM, Jeevan Chalke
<jeevan(dot)chalke(at)enterprisedb(dot)com> wrote:
> Hi,
>
> lfirst_node() changes are missing for List node type and I was thinking
> about adding those. But it looks like we cannot do so as List can be a
> T_List, T_IntList, or T_OidList. So I am OK with that.
Thanks for investigating the case of T_List.
>
> Apart from this, changes look good to me. Everything works fine.
>
> As we are now doing it for lfirst(), can we also do this for linitial()?
> I did not find any usage for lsecond(), lthird(), lfourth() and llast()
> though.
>
> Attached patch for replacing linitial() with linital_node() appropriately in
> planner.c
>
Ok. The patch looks good to me. It compiles and make check passes.
Here are both the patches rebased on the latest sources.
I am marking this commitfest entry as "ready for committer".
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Use-lfirst_node-instead-of-lfirst-wherever-suitable-_v2.patch | text/x-patch | 14.8 KB |
| 0002-Use-linitial_node-instead-of-linitial-wherever-suita_v2.patch | text/x-patch | 4.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2017-09-05 12:14:09 | Re: Copyright in partition.h and partition.c |
| Previous Message | Rajkumar Raghuwanshi | 2017-09-05 11:55:03 | Re: advanced partition matching algorithm for partition-wise join |