From: | Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com> |
---|---|
To: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: dropping partitioned tables without CASCADE |
Date: | 2017-02-23 06:40:38 |
Message-ID: | CAFjFpRdg8rLAjgSei3kNQX=AB-zT6U3=ML2_2AuiJBNb7VYc1A@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
I think this is ready for committer.
On Thu, Feb 23, 2017 at 12:02 PM, Amit Langote
<Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> wrote:
> On 2017/02/22 21:24, Ashutosh Bapat wrote:
>> On Wed, Feb 22, 2017 at 11:11 AM, Amit Langote wrote:
>>> + /*
>>> + * Unlike inheritance children, partition tables are expected to be dropped
>>> + * when the parent partitioned table gets dropped.
>>> + */
>>>
>>> Hmm. Partitions *are* inheritance children, so we perhaps don't need the
>>> part before the comma. Also, adding "automatically" somewhere in there
>>> would be nice.
>>>
>>> Or, one could just write: /* add an auto dependency for partitions */
>>
>> I changed it in the attached patch to
>> + /*
>> + * Partition tables are expected to be dropped when the parent partitioned
>> + * table gets dropped.
>> + */
>
> OK, thanks.
>
> Thanks,
> Amit
>
>
--
Best Wishes,
Ashutosh Bapat
EnterpriseDB Corporation
The Postgres Database Company
From | Date | Subject | |
---|---|---|---|
Next Message | Jim Nasby | 2017-02-23 06:41:00 | Re: [PATCH] Add pg_disable_checksums() and supporting infrastructure |
Previous Message | Michael Paquier | 2017-02-23 06:36:57 | Automatic cleanup of oldest WAL segments with pg_receivexlog |