Re: Postgres_fdw join pushdown - getting server crash in left outer join of three table

From: Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Rajkumar Raghuwanshi <rajkumar(dot)raghuwanshi(at)enterprisedb(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Postgres_fdw join pushdown - getting server crash in left outer join of three table
Date: 2016-05-18 17:37:42
Message-ID: CAFjFpRcy6UkC-28d4fbQJ0i9tH+d25BrOXm8Dy-xsf8yTiSbQQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, May 13, 2016 at 10:14 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:

> On Wed, Mar 23, 2016 at 12:53 PM, Robert Haas <robertmhaas(at)gmail(dot)com>
> wrote:
> > On Wed, Mar 23, 2016 at 5:24 AM, Rajkumar Raghuwanshi
> > <rajkumar(dot)raghuwanshi(at)enterprisedb(dot)com> wrote:
> >> Thanks Ashutosh for the patch. I have apply and retested it, now not
> getting
> >> server crash.
> >
> > Thanks for the report and the testing. I have committed the patch.
>
> So it's been pointed out to me off-list that I have committed a
> different patch than the one I intended to commit - that is, the one
> Michael sent, not the one Ashutosh sent. Oops.
>
> Reverting Michael's patch and applying Ashutosh's doesn't work any
> more due to conflicts in the regression tests. And in re-rereviewing
> Ashutosh's patch I came to feel like the comments in this area needed
> a lot more work.
>

Thanks for improving comments. Those are much better than mine.

--
Best Wishes,
Ashutosh Bapat
EnterpriseDB Corporation
The Postgres Database Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2016-05-18 17:39:53 Re: foreign table batch inserts
Previous Message Tom Lane 2016-05-18 17:16:03 Re: explain analyze does not report actual rows correctly?