Missing break statement after transformCallStmt in transformStmt

From: Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Missing break statement after transformCallStmt in transformStmt
Date: 2018-03-07 06:00:53
Message-ID: CAFjFpRcOTHZSFfHNwhAe4DmS+qvWmqK_UW3QF3wG8e0pAKW0tA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

HI,
Commit 76b6aa41f41db66004b1c430f17a546d4102fbe7 a new case for
CallStmt in transformStmt but forgot to add a break statement at the
end of the case. This doesn't create any problems since the default
case to which it continues without break doesn't change the result.
But this is going to cause problems in future when somebody adds a
case after CallStmt.

Here's patch with fix.
--
Best Wishes,
Ashutosh Bapat
EnterpriseDB Corporation
The Postgres Database Company

Attachment Content-Type Size
pg_call_break.patch text/x-patch 368 bytes

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrey Borodin 2018-03-07 06:11:27 Re: [WIP PATCH] Index scan offset optimisation using visibility map
Previous Message Michael Paquier 2018-03-07 05:05:02 Re: Comment on top of RangeVarGetRelidExtended in namespace.c mentioning RangeVarGetRelid