From: | Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com> |
---|---|
To: | Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Push down more full joins in postgres_fdw |
Date: | 2017-01-03 08:28:23 |
Message-ID: | CAFjFpRc6y6iPhUL9ketrdU+NL+W8qAnzq1-0fkMUgmKSB0ggrA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
>
> I updated the patch a bit further: simplified the function name
> (s/build_subquery_rel_tlists/build_subquery_tlists/), and revised comments a
> little bit. Attached is an updated version
> (postgres-fdw-subquery-support-v14.patch). And I rebased another patch for
> PHVs against that patch, which is also attached
> (postgres-fdw-phv-pushdown-v14.patch).
>
Few comments
In build_subquery_tlists(), why don't we handle base relations?
+ if (foreignrel->reloptkind != RELOPT_JOINREL)
+ return;
Also, in this function, if fpinfo->tlist is already set, why do we want to
build it again?
In build_tlist_to_deparse(), if fpinfo->tlist for the given relation is set, we
should just return it rather than constructing it again.
--
Best Wishes,
Ashutosh Bapat
EnterpriseDB Corporation
The Postgres Database Company
From | Date | Subject | |
---|---|---|---|
Next Message | valeriof | 2017-01-03 09:11:15 | Logical decoding - filtering tables |
Previous Message | Magnus Hagander | 2017-01-03 07:46:16 | Re: [PATCH] Reload SSL certificates on SIGHUP |