Re: Missing can't-assign-to-constant checks in plpgsql

From: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Missing can't-assign-to-constant checks in plpgsql
Date: 2022-05-01 17:25:17
Message-ID: CAFj8pRDsT6qG0oiVn6zac-+H5zjTZ6TRRZOmK_g-=FUVzP5Wgg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi

>> Regardless of which way we handle that point, I'm inclined to
>> change this only in HEAD. Probably people wouldn't thank us
>> for making the back branches more strict.
>>
>
> +1
>
> I can implement these checks in plpgsql_check. So possible issues can be
> detected and fixed on older versions by using plpgsql_check.
>

new related checks are implemented on plpgsql_check 2.1.4

Regards

Pavel

>
> Regards
>
> Pavel
>
>
>> regards, tom lane
>>
>> PS: I didn't do it here, but I'm kind of tempted to pull out
>> all the cursor-related tests in plpgsql.sql and move them to
>> a new test file under src/pl/plpgsql/src/sql/. They look
>> pretty self-contained, and I doubt they're worth keeping in
>> the core tests.
>>
>>

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message David G. Johnston 2022-05-01 19:34:43 Re: ERROR: type of parameter 1 (fruit2) does not match that when preparing the plan (fruit1)
Previous Message Tom Lane 2022-05-01 17:08:57 Re: ERROR: type of parameter 1 (fruit2) does not match that when preparing the plan (fruit1)