Re: Schema variables - new implementation for Postgres 15

From: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: Julien Rouhaud <rjuju123(at)gmail(dot)com>, Erik Rijkers <er(at)xs4all(dot)nl>, Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>, Joel Jacobson <joel(at)compiler(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Schema variables - new implementation for Postgres 15
Date: 2022-08-20 18:10:39
Message-ID: CAFj8pRDiC=jyXs9xzzX-XXXu95nqN-0raoFQ8LU2WuWMyDd8Ag@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

pá 19. 8. 2022 v 22:54 odesílatel Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
napsal:

> > diff --git a/src/backend/parser/parse_relation.c
> b/src/backend/parser/parse_relation.c
> > index f6b740df0a..b3bee39457 100644
> > --- a/src/backend/parser/parse_relation.c
> > +++ b/src/backend/parser/parse_relation.c
> > @@ -3667,8 +3667,8 @@ errorMissingColumn(ParseState *pstate,
> > ereport(ERROR,
> > (errcode(ERRCODE_UNDEFINED_COLUMN),
> > relname ?
> > - errmsg("column %s.%s does not exist",
> relname, colname) :
> > - errmsg("column \"%s\" does not exist",
> colname),
> > + errmsg("column or variable %s.%s does not
> exist", relname, colname) :
> > + errmsg("column or variable \"%s\" does
> not exist", colname),
> > state->rfirst ? closestfirst ?
> > errhint("Perhaps you meant to reference
> the column \"%s.%s\".",
> >
> state->rfirst->eref->aliasname, closestfirst) :
>
> This is in your patch 12. I wonder -- if relname is not null, then
> surely this is a column and not a variable, right? So only the second
> errmsg() here should be changed, and the first one should remain as in
> the original.
>

Yes, it should work. I changed it in today patch

Thank you for tip

Regards

Pavel

>
> --
> Álvaro Herrera PostgreSQL Developer —
> https://www.EnterpriseDB.com/
>

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Erik Rijkers 2022-08-20 18:44:49 Re: Schema variables - new implementation for Postgres 15
Previous Message Pavel Stehule 2022-08-20 18:09:20 Re: Schema variables - new implementation for Postgres 15