| From: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
|---|---|
| To: | Mikhail Gribkov <youzhick(at)gmail(dot)com> |
| Cc: | Ted Yu <yuzhihong(at)gmail(dot)com>, Nikita Malakhov <hukutoc(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Ian Lawrence Barwick <barwick(at)gmail(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Sergey Shinderuk <s(dot)shinderuk(at)postgrespro(dot)ru>, Ivan Panchenko <wao(at)mail(dot)ru>, Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Greg Nancarrow <gregn4422(at)gmail(dot)com>, Teodor Sigaev <teodor(at)sigaev(dot)ru>, Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Subject: | Re: On login trigger: take three |
| Date: | 2023-01-16 06:09:51 |
| Message-ID: | CAFj8pRDhsVyKAXDZmzPO5Utwo6W73N9_Kjd6=zqQGE6mAa57yA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
ne 15. 1. 2023 v 7:32 odesílatel Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
napsal:
> Hi
>
>
>> On Thu, Jan 12, 2023 at 9:51 AM Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
>> wrote:
>>
>>> Hi
>>>
>>> I checked this patch and it looks well. All tests passed. Together with
>>> https://commitfest.postgresql.org/41/4013/ it can be a good feature.
>>>
>>> I re-tested impact on performance and for the worst case looks like less
>>> than 1% (0.8%). I think it is acceptable. Tested pgbench scenario "SELECT
>>> 1"
>>>
>>> pgbench -f ~/test.sql -C -c 3 -j 5 -T 100 -P10 postgres
>>>
>>> 733 tps (master), 727 tps (patched).
>>>
>>> I think raising an exception inside should be better tested - not it is
>>> only in 001_stream_rep.pl - generally more tests are welcome - there
>>> are no tested handling exceptions.
>>>
>>
> Thank you
>
> check-world passed without problems
> build doc passed without problems
> I think so tests are now enough
>
> I'll mark this patch as ready for committer
>
Unfortunately, I forgot one important point. There are not any tests
related to backup.
I miss pg_dump related tests.
I mark this patch as waiting on the author.
Regards
Pavel
> Regards
>
> Pavel
>
>
>
>
>>
>>> Regards
>>>
>>> Pavel
>>>
>>>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2023-01-16 06:19:36 | Re: Perform streaming logical transactions by background workers and parallel apply |
| Previous Message | Ankit Kumar Pandey | 2023-01-16 06:08:45 | Re: Todo: Teach planner to evaluate multiple windows in the optimal order |