From: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | Adam Brightwell <adam(dot)brightwell(at)crunchydatasolutions(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com>, dinesh kumar <dineshkumar02(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: proposal: multiple psql option -c |
Date: | 2015-11-05 18:42:52 |
Message-ID: | CAFj8pRDYyit27SkWCk9s6L-8mfPUZp0B+ZRmwGsY2oNfZmre=A@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
2015-11-05 17:27 GMT+01:00 Robert Haas <robertmhaas(at)gmail(dot)com>:
> On Tue, Nov 3, 2015 at 10:16 AM, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
> wrote:
> >> The documentation included in this patch doesn't really make it clear
> >> why -g is different from or better than -c.
> >
> > I wrote some text. But needs some work of native speaker.
>
> It does. It would be nice if some kind reviewer could help volunteer
> to clean that up.
>
> Upthread, it was suggested that this option be called -C rather than
> -g, and personally I like that better. I don't really think there's
> anything "grouped" about the -g option; it's just an upgraded version
> of -c that does what we probably should have had -C do from the
> beginning, but now don't want to change out of a concern for
> backward-compatibility. I would propose to change not only the
> user-visible option name but all of the internal things that call this
> "group" or "grouped". Maybe introduce ACT_COMMAND_LINE or similar
> instead of ACT_GROUP_COMMANDS.
>
-C is good, and if there will not by any objection, I am for it
>
> Whatever else we do here, -1 on having both _MainLoop and MainLoop as
> function names. That can't be anything but confusing.
>
I'll have free time at weekend, and I'll check it.
Regards
Pavel
>
> --
> Robert Haas
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
From | Date | Subject | |
---|---|---|---|
Next Message | Pavel Stehule | 2015-11-05 18:48:04 | Re: Request: pg_cancel_backend variant that handles 'idle in transaction' sessions |
Previous Message | Robert Haas | 2015-11-05 18:36:40 | Re: Bitmap index scans use of filters on available columns |