Re: Tuple sort is broken. It crashes on simple test.

From: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
To: Peter Geoghegan <pg(at)heroku(dot)com>
Cc: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Mithun Cy <mithun(dot)cy(at)enterprisedb(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
Subject: Re: Tuple sort is broken. It crashes on simple test.
Date: 2017-01-16 18:38:23
Message-ID: CAFj8pRDYf2AqgCiaOb4eqNX4VkX6LjrYZn1fbWLO8uENCc-Cvw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

2017-01-16 19:24 GMT+01:00 Peter Geoghegan <pg(at)heroku(dot)com>:

> On Mon, Jan 16, 2017 at 3:48 AM, Michael Paquier
> <michael(dot)paquier(at)gmail(dot)com> wrote:
> > Indeed. It crashes for me immediately by adding an ORDER BY:
> > select count(distinct t) from seq_tab order by 1;
>
> The problem was that one particular call to the macro
> RELEASE_SLAB_SLOT() happened to lack a test-for-NULL-argument needed
> by pass-by-value datum cases. The other two RELEASE_SLAB_SLOT() calls
> already have such a check.
>
> Attached patch fixes the bug.
>
>
Should not be enhanced regress tests too?

Regards

Pavel

> --
> Peter Geoghegan
>
>
> --
> Sent via pgsql-hackers mailing list (pgsql-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-hackers
>
>

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2017-01-16 18:40:30 Re: Patch to implement pg_current_logfile() function
Previous Message Peter Geoghegan 2017-01-16 18:24:20 Re: Tuple sort is broken. It crashes on simple test.