checking variadic "any" argument in parser - should be array

From: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
To: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: checking variadic "any" argument in parser - should be array
Date: 2013-01-26 03:52:41
Message-ID: CAFj8pRDSYTpBFcq0m6rOB11431LCJuLDd4f5uNO8+NjqwY=YVA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hello Tom

you did comment

! <----><------><------> * Non-null argument had better be an array.
The parser doesn't
! <----><------><------> * enforce this for VARIADIC ANY functions
(maybe it should?), so
! <----><------><------> * that check uses ereport not just elog.
! <----><------><------> */

So I moved this check to parser.

It is little bit stricter - requests typed NULL instead unknown NULL,
but it can mark error better and early

Regards

Pavel

Attachment Content-Type Size
variadic_any_parser_check.patch application/octet-stream 10.7 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2013-01-26 03:59:28 Re: COPY FREEZE has no warning
Previous Message Tom Lane 2013-01-26 03:50:00 Re: proposal - assign result of query to psql variable