Re: Unfortunate choice of short switch name in pgbench

From: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Unfortunate choice of short switch name in pgbench
Date: 2014-02-25 20:03:36
Message-ID: CAFj8pRDRjVoHjXnxzxnKfk0Op6mWfBFNXHNB=irs8AFAtcNUfA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

2014-02-25 20:49 GMT+01:00 Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>:

> I just wasted some time puzzling over strange results from pgbench.
> I eventually realized that I'd been testing against the wrong server,
> because rather than "-p 65432" I'd typed "-P 65432", thereby invoking
> the recently added --progress option. pgbench has no way to know that
> that isn't what I meant; the fact that both switches take integer
> arguments doesn't help.
>
> To fix this, I propose removing the -P short form and only allowing the
> long --progress form. I won't argue that this feature is completely
> useless, but for sure it's not something I'd want more often than once
> in a blue moon. So I think it does not need to have a short form; and
> for sure it doesn't need a short form that's so easily confused with a
> commonly used switch.
>
> If no objections, I'll go make that change.
>

+1

Pavel

>
> regards, tom lane
>
>
> --
> Sent via pgsql-hackers mailing list (pgsql-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-hackers
>

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2014-02-25 20:06:50 Re: Unfortunate choice of short switch name in pgbench
Previous Message Jeremy Harris 2014-02-25 19:55:08 Re: Minor performance improvement in transition to external sort