| From: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: possibility to specify template database for pg_regress |
| Date: | 2017-02-14 04:35:52 |
| Message-ID: | CAFj8pRD0Tv779DZcOAF97e=GLeKV8PH3uKKRH+V26droJpR0_Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
2017-02-14 3:50 GMT+01:00 Andres Freund <andres(at)anarazel(dot)de>:
> On 2017-02-14 11:46:52 +0900, Michael Paquier wrote:
> > > I still fail to see why --use-existing as suggested in
> > > https://www.postgresql.org/message-id/20170208002900.
> vkldujzfkwbvqqq7(at)alap3(dot)anarazel(dot)de
> > > isn't sufficient.
> >
> > Some tests create objects without removing them, meaning that
> > continuous runs would fail with only --use-existing. This patch brings
> > value in such cases.
>
> You can trivially script the CREATE/DROP DB outside with
> --use-existing. Which seems a lot more flexible than adding more and
> more options to pg_regress.
>
Using template is natural and very simply solution - more it doesn't need
any outer scripts - so infrastructure for test can be pretty simply in this
case.
Regards
Pavel
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2017-02-14 05:11:06 | Re: [Bug fix] PQsendQuery occurs error when target_session_attrs is set to read-write |
| Previous Message | Amit Kapila | 2017-02-14 04:07:08 | Re: parallelize queries containing subplans |