From: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
---|---|
To: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Subject: | broken logic of simple_eval_resowner after CALL and COMMIT inside procedure |
Date: | 2020-10-12 14:15:51 |
Message-ID: | CAFj8pRD-90xCen9cn298tnyrudfz-EWsvthk8zJ9zRjGzvAk2w@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi
Inline handler creates simple_eval_resowner (without parent).
Inside plpgsql_estate_setup this value is assigned to
estate->simple_eval_resowner
<-->if (simple_eval_resowner)
<--><-->estate->simple_eval_resowner = simple_eval_resowner;
<-->else
<--><-->estate->simple_eval_resowner = shared_simple_eval_resowner;
When we call procedure with inner COMMIT, then when "before_lxid !=
after_lxid" following code is
executed.
<--><-->estate->simple_eval_estate = NULL;
<--><-->estate->simple_eval_resowner = NULL;
<--><-->plpgsql_create_econtext(estate);
and
fragment from plpgsql_create_econtext
<-->/*
<--> * Likewise for the simple-expression resource owner.
<--> */
<-->if (estate->simple_eval_resowner == NULL)
<-->{
<--><-->if (shared_simple_eval_resowner == NULL)
<--><--><-->shared_simple_eval_resowner =
<--><--><--><-->ResourceOwnerCreate(TopTransactionResourceOwner,
<--><--><--><--><--><--><--><--><-->"PL/pgSQL simple expressions");
<--><-->estate->simple_eval_resowner = shared_simple_eval_resowner;
<-->}
In this case simple_eval_resowner from inline handler is overwritten and
only shared_simple_eval_resowner will be used.
So is it "estate->simple_eval_resowner = NULL;" error (without other
conditions)?
Regards
Pavel
From | Date | Subject | |
---|---|---|---|
Next Message | Pavel Stehule | 2020-10-12 14:36:00 | Re: broken logic of simple_eval_resowner after CALL and COMMIT inside procedure |
Previous Message | Bruce Momjian | 2020-10-12 14:14:45 | Re: Feature improvement: can we add queryId for pg_catalog.pg_stat_activity view? |