| From: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Daniel Verite <daniel(at)manitou-mail(dot)org>, Corey Huinker <corey(dot)huinker(at)gmail(dot)com>, Gilles Darold <gilles(dot)darold(at)dalibo(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: proposal: psql \setfileref |
| Date: | 2016-11-17 18:53:58 |
| Message-ID: | CAFj8pRD=pfNUKSca76eXa3Uyc9z=ww4VQ=n0VuRDd20kmmp3Dg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi
2016-11-17 12:00 GMT+01:00 Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>:
>
> Hi
>
> a independent implementation of parametrized queries can looks like
> attached patch:
>
> this code is simple without any unexpected behave.
>
> parameters are used when user doesn't require escaping and when
> PARAMETRIZED_QUERIES variable is on
>
> Regards
>
here is a Daniel's syntax patch
The independent implementation of using query parameters is good idea, the
patch looks well, and there is a agreement with Tom.
I implemented a Daniel proposal - it is few lines, but personally I prefer
curly bracket syntax against `` syntax. When separator is double char, then
the correct implementation will not be simple - the bad combinations "` ``,
`` `" should be handled better. I wrote my arguments for my design, but if
these arguments are not important for any other, then I can accept any
other designs.
regards
Pavel
>
> Pavel
>
>
| Attachment | Content-Type | Size |
|---|---|---|
| psql-backtick-hex-output.patch | text/x-patch | 2.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2016-11-17 19:14:24 | Re: Declarative partitioning - another take |
| Previous Message | Claudio Freire | 2016-11-17 18:42:55 | Re: Vacuum: allow usage of more than 1GB of work mem |