Re: proposal: searching in array function - array_position

From: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Marko Tiikkaja <marko(at)joh(dot)to>, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, Petr Jelinek <petr(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>
Subject: Re: proposal: searching in array function - array_position
Date: 2015-03-19 06:59:51
Message-ID: CAFj8pRCrxPU8fW_EGEPm5QOMjH1VKFNcvfdi-v4hzeXzzshaHQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

2015-03-18 20:03 GMT+01:00 Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>:

> Pavel Stehule wrote:
> > 2015-03-18 12:41 GMT+01:00 Marko Tiikkaja <marko(at)joh(dot)to>:
>
> > >> I am thinking, so this behave is correct (there is no other
> > >> possible), but it is only corner case for this functionality - and
> > >> if you are thinking, so better to disallow it, I am not against. My
> > >> main focus is 1ND array.
> > >
> > > A nonsensical answer for multi-dimensional arrays is worse than no
> answer
> > > at all. I think raising an exception is better.
> > >
> >
> > I have not problem with it.
>
> Pushed after adding error checks there and fixing the docs to match.
> Please verify.
>

it is looking well, thank you.

small issue - there is not documented, so multidimensional arrays are not
supported,

Regards

Pavel

>
> --
> Álvaro Herrera http://www.2ndQuadrant.com/
> PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
>

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2015-03-19 07:25:38 Re: pg_dump quietly ignore missing tables - is it bug?
Previous Message Michael Paquier 2015-03-19 04:43:52 Re: Table-level log_autovacuum_min_duration