Re: obsolete code

2013/2/1 Andrew Dunstan <andrew(at)dunslane(dot)net>:
>
> On 02/01/2013 10:38 AM, Tom Lane wrote:
>>
>> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>>>
>>> fmgr.c contains this:
>>> * DEPRECATED, DO NOT USE IN NEW CODE
>>> Should we just drop all support for the old interface now?
>>
>> Is there any actual benefit to removing it? I don't recall that
>> it's been the source of any maintenance burden. I'd be fine with
>> dropping it if it were costing us something measurable, but ...
>>
>>
>
>
>
> My hope was that if we got rid of the old stuff we wouldn't need to use
>
> PG_FUNCTION_INFO_V1(myfunc);
>

removing function descriptor should not be good idea - it can be used
for some annotation.

I had a similar issue - and can be nice, if it is solved with some assertions.

Regards

Pavel

>
>
> in external modules any more (I recently got bitten through forgetting this
> and it cost me an hour or two).
>
> cheers
>
> andrew
>
>
>
>
> --
> Sent via pgsql-hackers mailing list (pgsql-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-hackers