| From: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Oleg Bartunov <obartunov(at)postgrespro(dot)ru>, Michael Paquier <michael(at)paquier(dot)xyz>, Stas Kelvich <s(dot)kelvich(at)postgrespro(dot)ru>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, David Steele <david(at)pgmasters(dot)net>, Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: jsonpath |
| Date: | 2019-03-18 20:24:33 |
| Message-ID: | CAFj8pRC47SB1HX39ecd98Uiizw1UgNLtX_wJA=JrGCLGF6Kvcg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
po 18. 3. 2019 v 21:23 odesílatel Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> napsal:
> Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru> writes:
> > On Mon, Mar 18, 2019 at 10:08 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> >> Just another minor bitch about this patch: jsonpath_scan.l has
> introduced
> >> a typedef called "keyword". This is causing pgindent to produce
> seriously
> >> ugly results in libpq, and probably in other places where that is used
> as
> >> a field or variable name. Please rename that typedef to something less
> >> generic.
>
> > Ooops... I propose to rename it to KeyWord, which is already
> > typedef'ed in formatting.c. See the attached patch. Is it OK?
>
> I had in mind JsonPathKeyword or something like that. If you re-use
> formatting.c's typedef name, pgindent won't care, but it's possible
> you'd be in for unhappiness when trying to look at these structs in
> gdb for instance.
>
JsonPathKeyword is better verbose
Pavel
> regards, tom lane
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2019-03-18 20:41:26 | Re: [PATCH] remove repetitive characters in fdwhandler.sgml |
| Previous Message | Tom Lane | 2019-03-18 20:23:03 | Re: jsonpath |