Re: wrapping in extended mode doesn't work well with default pager

From: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
To: Sergey Muraviov <sergey(dot)k(dot)muraviov(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Greg Stark <stark(at)mit(dot)edu>, Emre Hasegeli <emre(at)hasegeli(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: wrapping in extended mode doesn't work well with default pager
Date: 2014-05-14 06:32:26
Message-ID: CAFj8pRC0fzEDD+hs_xrrZzqBLct=S1i93hW54k0m-HRugGE+3A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hello

With this patch it works perfect

Thank you

Regards

Pavel

2014-05-13 21:33 GMT+02:00 Sergey Muraviov <sergey(dot)k(dot)muraviov(at)gmail(dot)com>:

> Please check this patch.
>
>
> 2014-05-12 22:56 GMT+04:00 Sergey Muraviov <sergey(dot)k(dot)muraviov(at)gmail(dot)com>:
>
> Hi.
>>
>> I'll try to fix it tomorrow.
>>
>>
>> 2014-05-12 18:42 GMT+04:00 Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>:
>>
>> Greg Stark <stark(at)mit(dot)edu> writes:
>>> > On Mon, May 12, 2014 at 2:12 PM, Greg Stark <stark(at)mit(dot)edu> wrote:
>>> >> Hm, there was an off by one error earlier in some cases, maybe we
>>> >> fixed it by breaking other case. Will investigate.
>>>
>>> > Those spaces are coming from the ascii wrapping indicators. i.e. the
>>> periods in:
>>>
>>> Ah. I wonder whether anyone will complain that the format changed?
>>>
>>> > Apparently we used to print those with border=1 in normal mode but in
>>> > expanded mode we left out the space for those on the outermost edges
>>> > since there was no need for them. If we put them in for wrapped mode
>>> > then we'll be inconsistent if we don't for nonwrapped mode though. And
>>> > if we don't put them in for wrapped mode then there's no way to
>>> > indicate wrapping versus newlines.
>>>
>>> Barring anyone complaining that the format changed, I'd say the issue
>>> is not that you added them but that the accounting for line length
>>> fails to include them.
>>>
>>> regards, tom lane
>>>
>>
>>
>>
>> --
>> Best regards,
>> Sergey Muraviov
>>
>
>
>
> --
> Best regards,
> Sergey MuraviovH
>

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2014-05-14 06:55:20 Re: wrapping in extended mode doesn't work well with default pager
Previous Message Tom Lane 2014-05-14 06:11:04 Re: regression tests fail for different block sizes