Re: IF (NOT) EXISTS in psql-completion

From: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
To: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: IF (NOT) EXISTS in psql-completion
Date: 2016-11-23 06:12:00
Message-ID: CAFj8pRBxgUrg-6CKbVOy4VqwSFkrf--uCzj3q-vd9FgpSGV+qQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi

2016-11-15 12:26 GMT+01:00 Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)
jp>:

> Hello, I rebased this patch on the current master.
>
> At Mon, 31 Oct 2016 10:15:48 +0900 (Tokyo Standard Time), Kyotaro
> HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> wrote in <
> 20161031(dot)101548(dot)162143279(dot)horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
> > Anyway, I fixed space issues and addressed the
> > COMPLETE_WITH_QUERY()'s almost unused parameter problem. And
> > tried to write a README files.
>
> tab-complete.c have gotten some improvements after this time.
>
> 577f0bdd2b8904cbdfde6c98f4bda6fd93a05ffc psql: Tab completion for
> renaming enum values.
> 927d7bb6b120a2ca09a164898f887eb850b7a329 Improve tab completion for
> CREATE TRIGGER.
> 1d15d0db50a5f39ab69c1fe60f2d5dcc7e2ddb9c psql: Tab-complete LOCK [TABLE]
> ... IN {ACCESS|ROW|SHARE}.
>
> The attached patchset is rebsaed on the master including these
> patches.
>

I checked patches 0001, 0002, 0003 patches

There are no any problems with patching, compiling, it is working as
expected

These patches can be committed separately - they are long, but the code is
almost mechanical

The README is perfect

Regards

Pavel

>
> regards,
>
> --
> Kyotaro Horiguchi
> NTT Open Source Software Center
>

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dilip Kumar 2016-11-23 07:01:24 Re: Parallel bitmap heap scan
Previous Message Pavel Stehule 2016-11-23 05:16:33 Re: patch: function xmltable