From: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
---|---|
To: | Petr Jelinek <petr(at)2ndquadrant(dot)com> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: proposal: disallow operator "=>" and use it for named parameters |
Date: | 2015-02-19 20:15:37 |
Message-ID: | CAFj8pRBrV5FLV5ZTb-p4gzQmE1v_k46S2SDkc=3UN+ipO-103g@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
2015-02-19 16:06 GMT+01:00 Petr Jelinek <petr(at)2ndquadrant(dot)com>:
> On 19/01/15 17:14, Pavel Stehule wrote:
>
>>
>>
>> 2015-01-19 14:27 GMT+01:00 Robert Haas <robertmhaas(at)gmail(dot)com
>> <mailto:robertmhaas(at)gmail(dot)com>>:
>>
>> On Mon, Jan 19, 2015 at 2:59 AM, Pavel Stehule
>> <pavel(dot)stehule(at)gmail(dot)com <mailto:pavel(dot)stehule(at)gmail(dot)com>> wrote:
>> >> I think you should just remove the WARNING, not change it to an
>> error.
>> >> If somebody wants to quote the operator name to be able to continue
>> >> using it, I think that's OK.
>> >
>> > It looks so quoting doesn't help here
>> >
>> > + CREATE OPERATOR "=>" (
>> > + leftarg = int8,<--><------>-- right unary
>> > + procedure = numeric_fac
>> > + );
>> > + ERROR: syntax error at or near "("
>> > + LINE 1: CREATE OPERATOR "=>" (
>> > + ^
>>
>> Well then the error check is just dead code. Either way, you don't
>> need it.
>>
>>
>> yes, I removed it
>>
>>
> I am marking this as Ready For Committer, the patch is trivial and works
> as expected, there is nothing to be added to it IMHO.
>
> The "=>" operator was deprecated for several years so it should not be too
> controversial either.
>
Thank you very much
Pavel
>
>
> --
> Petr Jelinek http://www.2ndQuadrant.com/
> PostgreSQL Development, 24x7 Support, Training & Services
>
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2015-02-19 20:23:55 | Re: Turning recovery.conf into GUCs |
Previous Message | Alvaro Herrera | 2015-02-19 20:14:57 | Re: deparsing utility commands |