Re: proposal: psql command \graw

From: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
To: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: proposal: psql command \graw
Date: 2017-11-09 20:12:02
Message-ID: CAFj8pRBojBwftXZXZYHv9PMvbXxzhszyVj7rjoFQO75jmfWmBg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

2017-11-09 21:03 GMT+01:00 Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>:

>
> Hello Pavel,
>
> I hope so I fixed all mentioned issues.
>>
>
> Patch applies with a warning:
>
> > git apply ~/psql-graw-2.patch
> /home/fabien/psql-graw-2.patch:192: new blank line at EOF.
> +
> warning: 1 line adds whitespace errors.
>
> Otherwise it compiles. "make check" ok. doc gen ok.
>
> Two spurious empty lines are added before StoreQueryTuple.
>
> Doc: "If <literal>+</literal> is appended to the command name, a column
> names are displayed."
>
> I suggest instead: "When <literal>+</literal> is appended, column names
> are also displayed."
>
> ISTM that you can remove "force_column_header" and just set "tuple_only"
> to what you need, that is you do not need to change anything in function
> "print_unaligned_text".
>

Last point is not possible - I would not to break original tuple only mode.

Pavel

>
> --
> Fabien.
>

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2017-11-09 20:15:52 Re: Simplify ACL handling for large objects and removal of superuser() checks
Previous Message Paul Ramsey 2017-11-09 20:11:49 Inlining functions with "expensive" parameters