| From: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
|---|---|
| To: | Julien Rouhaud <rjuju123(at)gmail(dot)com> |
| Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Stephen Frost <sfrost(at)snowman(dot)net>, Bruce Momjian <bruce(at)momjian(dot)us>, Christoph Berg <myon(at)debian(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: compute_query_id and pg_stat_statements |
| Date: | 2021-05-12 06:58:45 |
| Message-ID: | CAFj8pRBiBsReXskjmU6c-+HHS2Q5=7eB9JJJDXvVbUZnR+FmFA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
st 12. 5. 2021 v 8:10 odesílatel Julien Rouhaud <rjuju123(at)gmail(dot)com> napsal:
> On Wed, May 12, 2021 at 07:49:13AM +0200, Pavel Stehule wrote:
> >
> > > Ah, I missed that case. And we are wanting to use pg_stat_statements
> > > with (almost) zero-config? How about the following behavior?
> > >
> > >
> > Until now, the pg_stat_statements was zero-config. So the change is not
> > user friendly.
>
> Apart from configuring shared_preload_libraries, but agreed.
>
> > The idea so pg_stat_statements requires enabled computed_query_id is not
> > good. There should be dependency only on the queryid column.
>
> I agree that requiring to change compute_query_id when you already added
> pg_stat_statements in shared_preload_libraries isn't good, and the patch I
> sent
> yesterday would fix that.
>
I don't like the idea of implicit force enabling any feature flag, but it
is better than current design. But it doesn't look like a robust solution.
Does it mean that if somebody disables computed_query_id, then
pg_stat_statements will not work?
Why is there the strong dependency between computed_query_id and
pg_stat_statements? Can this dependency be just optional?
Regards
Pavel
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2021-05-12 06:59:09 | Re: PG 14 release notes, first draft |
| Previous Message | Amit Langote | 2021-05-12 06:41:04 | Re: PG 14 release notes, first draft |